Skip to content

[Simulation.Core] use getNodeObjects for cleaner iteration over objects #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 1 commit into from
Feb 10, 2026
+4 −6
Merged

[Simulation.Core] use getNodeObjects for cleaner iteration over objects #5945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions Sofa/framework/Simulation/Core/src/sofa/simulation/TopologyChangeVisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,9 @@ Visitor::Result TopologyChangeVisitor::processNodeTopDown(simulation::Node* node
#endif

// search for topological mapping, run the mapping first. Do not stop the propagation of parent topology
for (simulation::Node::ObjectIterator it = node->object.begin(); it != node->object.end(); ++it)
for (auto* obj : node->getNodeObjects<sofa::core::topology::TopologicalMapping>())
{
sofa::core::topology::TopologicalMapping* obj = dynamic_cast<sofa::core::topology::TopologicalMapping*>(it->get());
if (obj != nullptr) // find a TopologicalMapping node among the brothers (it must be the first one written)
if (obj != nullptr)
{
if(obj->propagateFromInputToOutputModel() && obj->getFrom() == m_source) //node != root){ // the propagation of topological changes comes (at least) from a father node, not from a brother
{
Expand All @@ -92,10 +91,9 @@ Visitor::Result TopologyChangeVisitor::processNodeTopDown(simulation::Node* node

void TopologyChangeVisitor::processNodeBottomUp(simulation::Node* node)
{
for (simulation::Node::ObjectIterator it = node->object.begin(); it != node->object.end(); ++it)
for (auto* obj : node->getNodeObjects<sofa::core::topology::TopologicalMapping>())
{
sofa::core::topology::TopologicalMapping* obj = dynamic_cast<sofa::core::topology::TopologicalMapping*>(it->get());
if (obj != nullptr) // find a TopologicalMapping node among the brothers (it must be the first one written)
if (obj != nullptr)
{
if(obj->propagateFromOutputToInputModel() && obj->getTo() == m_source) //node == root){
{
Expand Down