[Mapping] Fix rigid mapping init #5943
Open
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakpaul
added
pr: fix
hugtalbot
reviewed
Feb 6, 2026
| @@ -135,7 +135,8 @@ template <class TIn, class TOut> | |||
| sofa::Index RigidMapping<TIn, TOut>::getRigidIndex(sofa::Index pointIndex ) const | |||
| { | |||
| // do we really need this crap? | |||
Contributor
There was a problem hiding this comment.
Possibly ... no?
Suggested change
| // do we really need this crap? |
Contributor
Author
There was a problem hiding this comment.
This comment is from 2015 and the following code has been modified multiple times afterwards. So I would say that we might need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use right vector size for checking. This fixes a crash when the mapping was used with only "useX0=True".
I know this component needs way more fixing/refactoring. But this is just a fix keeping the ols implementation untouched for now.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if