-
Notifications
You must be signed in to change notification settings - Fork 341
[Core] Rename BaseObject to BaseComponent #5934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[ci-build][with-all-tests] |
|
[ci-depends-on] detected during build #5. All dependencies are merged/closed. Congrats! 👍 |
70326ce to
41376e3
Compare
|
[ci-depends-on] detected during build #6. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
c108dd7 to
eecf4db
Compare
|
[ci-depends-on] detected during build #8. To unlock the merge button, you must
|
eecf4db to
7f8d636
Compare
|
[ci-depends-on] detected during build #9. To unlock the merge button, you must
|
This PR implements a backward-compatible transition of the core object base type from
BaseObjecttoBaseComponentwhile ensuring existing code continues to compile during migration:BaseComponent(the new type).BaseObjectis a deprecated alias forBaseComponent(ensures existing code compiles without changes).#include <BaseObject.h>is a deprecated alias for#include <BaseComponent.h>(via header shim).toBaseObject()is a deprecated alias fortoBaseComponent()(forwarded internally to avoid breaking core builds).This deprecation layer does not work for code using its own forward-declared
BaseObject. Such code will fail with a redefinition error (e.g.,BaseObjectalready defined). Instead of the forward declaration ofBaseObject, we recommand to include<sofa/core/fwd.h>. Then, you can renameBaseObjectwithBaseComponent, although the deprecation layer should work.[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/575]
[ci-depends-on https://github.com/sofa-framework/Sofa.Qt/pull/30]
[ci-build][with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if