Skip to content

[Framework] BaseMatrix:: Remove warnings about overloaded-virtual about add() #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredroy wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −0
Open

[Framework] BaseMatrix:: Remove warnings about overloaded-virtual about add() #5931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc0548
remove warning about overloaded-virtual
fredroy Feb 4, 2026
be1e240
Merge branch 'master' into fix_warning_basematrix_add
fredroy Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sofa/framework/Core/src/sofa/core/behavior/MatrixAPICompatibility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ class AddToMatrixCompatMatrix : public sofa::linearalgebra::BaseMatrix

msg_error(component) << compatibilityMessage << "set is not a supported operation in the compatibility";
}
using linearalgebra::BaseMatrix::add;
void add(Index row, Index col, double v) override
{
if constexpr (c == matrixaccumulator::Contribution::MASS)
Expand Down Expand Up @@ -215,6 +216,7 @@ class ApplyConstraintCompat : public sofa::linearalgebra::BaseMatrix
SOFA_UNUSED(j);
SOFA_UNUSED(v);
}
using linearalgebra::BaseMatrix::add;
void add(Index row, Index col, double v) override
{
SOFA_UNUSED(row);
Expand Down
1 change: 1 addition & 0 deletions Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/BTDMatrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ class BTDMatrix : public linearalgebra::BaseMatrix

void set(Index i, Index j, double v) override;

using BaseMatrix::add;
void add(Index i, Index j, double v) override;

/**
Expand Down
1 change: 1 addition & 0 deletions Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/BlockFullMatrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class BlockFullMatrix : public linearalgebra::BaseMatrix

void set(Index i, Index j, double v) override;

using BaseMatrix::add;
void add(Index i, Index j, double v) override;

void clear(Index i, Index j) override;
Expand Down
2 changes: 2 additions & 0 deletions Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/CompressedRowSparseMatrixMechanical.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ class CompressedRowSparseMatrixMechanical final // final is used to allow the co
traits::vset(*this->wblock(i, j, true), bi, bj, static_cast<Real>(v) );
}

using BaseMatrix::add;

/**
* \brief add scalar v at element i, j of matrix
**/
Expand Down
2 changes: 2 additions & 0 deletions Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/EigenBaseSparseMatrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ class EigenBaseSparseMatrix : public linearalgebra::BaseMatrix



using BaseMatrix::add;

/// Schedule the addition of the value at the given place. Scheduled additions must be finalized using function compress().
void add( Index row, Index col, double value ) override{
if( value!=0.0 ) incoming.push_back( Triplet(row,col,(Real)value) );
Expand Down
Loading