Skip to content

Conversation

@alxbilger
Copy link
Contributor

Treating compilation warnings as errors is a good practice. However, SOFA has so many warnings that we cannot simply turn on this feature for the whole code base. Instead, I suggest to progressively add this feature for individual modules, and privately. For that, I introduced a CMake function.

I activated this feature for Sofa.Config and Sofa.Type. I expect new compilation errors that we will need to fix, before merging this PR.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: enhancement About a possible enhancement labels Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants