[Config] Introduce CMake function to treat compilation warnings as errors #5914
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treating compilation warnings as errors is a good practice. However, SOFA has so many warnings that we cannot simply turn on this feature for the whole code base. Instead, I suggest to progressively add this feature for individual modules, and privately. For that, I introduced a CMake function.
I activated this feature for Sofa.Config and Sofa.Type. I expect new compilation errors that we will need to fix, before merging this PR.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if