-
Notifications
You must be signed in to change notification settings - Fork 341
Quick test on current regression on the CI #5873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[ci-build][with-all-tests] |
|
I'm afraid to say that my fear were right. There is a mismatch of reference filename against current mechanicalObject names. And the ReadState is not returning false if the ref is not found. You can see that I change the name of a mechanicalObject and totally mess up the mass of several torus in the chain.scn but the regression is still passing:
|
|
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #8. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #9. To unlock the merge button, you must
|
|
Would be a real plus to detect / warn when a test reference is not found → closed |
Just checking that the regression fails if the state reference file (based on the mechanicalObject name) is not found
[with-all-tests]
[ci-depends-on https://github.com/sofa-framework/Regression/pull/98]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if