Skip to content

Fix crashes when changing Mouse operation #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugtalbot wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix crashes when changing Mouse operation #269

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
379b0e0
Fix crashes when changing Mouse operation
Jan 27, 2026
4008ebb
Apply suggestion from @hugtalbot
hugtalbot Feb 5, 2026
6660abf
Update SofaImGui/src/SofaImGui/windows/MouseManager.cpp
hugtalbot Feb 5, 2026
009f746
Update SofaImGui/src/SofaImGui/windows/MouseManager.cpp
hugtalbot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions SofaImGui/src/SofaImGui/windows/MouseManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
namespace windows
{



void showManagerMouseWindow(const char *const & windowNameMouseManager,
WindowState& winManagerMouse,
sofaglfw::SofaGLFWBaseGUI* baseGUI)
Expand All @@ -56,6 +54,9 @@ void showManagerMouseWindow(const char *const & windowNameMouseManager,
if (ImGui::CollapsingHeader(buttonNames.at(button).c_str()))
{
auto* operation = pickHandler->getOperation(button);

if(!operation) continue;

std::string currentOperationDescription;

for (const auto& [label, creator] : OperationFactory::getInstance()->registry)
Expand All @@ -73,6 +74,9 @@ void showManagerMouseWindow(const char *const & windowNameMouseManager,
if (ImGui::Selectable(creator->getDescription().c_str(), isSelected))
{
pickHandler->changeOperation(button, label);
operation = pickHandler->getOperation(button); // Re-fetch the operation after call to changeOperation()

if (!operation) continue;
}
if (isSelected)
ImGui::SetItemDefaultFocus();
Expand Down Expand Up @@ -108,7 +112,7 @@ void showManagerMouseWindow(const char *const & windowNameMouseManager,
float stiffness = fixOperation->getStiffness();
if (ImGui::SliderFloat("Stiffness", &stiffness, 0.0f, 100000.0f))
{
attachOperation->setStiffness(stiffness);
fixOperation->setStiffness(stiffness);
}
}
else if (auto* inciseOperation = dynamic_cast<InciseOperation*>(operation))
Expand Down
Loading