Add support for resolving IPv4-mapped IPv6 addresses#15
Merged
Conversation
…ped IPv6 addresses to be compared as IPv4 addresses
… be able to resolve IPv4-mapped IPv6 addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
MacAddressResolver.ResolveIPAddressToMacAddressAsyncdetermines that if an entry in the address table is IPv4, the IPv4-mapped IPv6 address is not equivalent to that entry.In order to be able to resolve IPv4-mapped IPv6 addresses to MAC addresses, this PR adds a new property
MacAddressResolver.ShouldResolveIPv4MappedIPv6Address.This PR also improves the
AddressTableEntry.Equalsmethod to be able to compare with IPv4-mapped IPv6 addresses to resolve this issue.