Add type validation for security_policy property.#1167
Open
reomin wants to merge 2 commits intosmarty-php:masterfrom
Open
Add type validation for security_policy property.#1167reomin wants to merge 2 commits intosmarty-php:masterfrom
reomin wants to merge 2 commits intosmarty-php:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes some issues where SecurityPolicy checks are silently skipped when the internal security_policy property is overwritten with a non-object value.
Currently, several SecurityPolicy enforcement paths rely on isset() and is_object() checks. If security_policy is set but is not an object, these checks are bypassed without any error, even when enableSecurity() has been called.
This PR makes the behavior more robust and consistent with the intended design of SecurityPolicy by enforcing stricter type handling.
Changes
security_policyfrompublictoprivategetSecurityPolicy()andsetSecurityPolicy()methods__set()method to validate type on assignmentgetSecurityPolicy()