Fix templates when running with redis and postgres disabled

[kyrbrbik]

Hi,
Installing the chart with redis and postgresql disabled somehow breaks every template that relies on common.names.fullname. It's probably getting it from the subcharts somehow so I've changed all the occurrences to mastodon.fullname

[jessebot]

huh, that's so weird, because I run with postgresl.enabled=false and redis.enabled=false I never got an issue. 🤔 Can you tell me what breaks means in this instance?

[kyrbrbik]

Oh yeah sorry didn't think it wouldn't be reproducible. The exact error is Error: INSTALLATION FAILED: template: mastodon/templates/_helpers.tpl:82:28: executing "mastodon.pvc.assets" at <include "common.names.fullname" .>: error calling include: template: no template "common.names.fullname" associated with template "gotpl"

Maybe you also need to disable elastic as it's also a subchart?

[kyrbrbik]

Hi, @jessebot have you had any time to look at this?

[jessebot]

No, but I will this weekend! Sorry, work has been killer!

[sMteX]

After extracting all dependencies, you can see the common.names.fullname template is defined in all of them:

• elasticsearch/charts/common/templates/_names.tpl
• elasticsearch/charts/kibana/charts/common/templates/_names.tpl
• postgresql/charts/common/templates/_names.tpl
• redis/charts/common/templates/_names.tpl

Where the common is a bitnamicharts common helm library. So it makes sense to me that if you choose to deploy Mastodon without these dependencies (we opted out of the search functionality, and have PostgreSQL and Redis separately, just connected to Mastodon), the subcharts don't get loaded and the name templates are missing.

However, looking at the code of that template:

{{- define "common.names.fullname" -}}
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}
{{- end -}}

it's identical to mastodon.fullname you have in _helpers.tpl. So that might be a way to go forward to fixing this issue as well.