-
Notifications
You must be signed in to change notification settings - Fork 25
chore: release slack-cli v3.11.0 #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks LGTM! Thanks so much for bringing these commits to a tag 🚀 ✨
| # @printf "$(FONT_BOLD)Git Tag$(FONT_RESET)\n" | ||
| # git tag v$(RELEASE_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡 praise: Thanks for keeping this commented for later remembers!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 64.85% 64.81% -0.04%
==========================================
Files 213 213
Lines 17550 17550
==========================================
- Hits 11382 11375 -7
- Misses 5103 5105 +2
- Partials 1065 1070 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mwbrooks Thanks for adding the |
Summary
This pull request updates the documentation for release v3.11.0 and disables the git tagging when running
make tag.We've disabled tagging when running
make tagto fix an issue with orphaned tagged commits. We'll continue to rework this in the future.Requirements