Skip to content

refactor(dashboards): use signal inputs internally#1487

Open
chintankavathia wants to merge 1 commit intomainfrom
refactor/dashboards/input/signals
Open

refactor(dashboards): use signal inputs internally#1487
chintankavathia wants to merge 1 commit intomainfrom
refactor/dashboards/input/signals

Conversation

@chintankavathia
Copy link
Member

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several components to utilize Angular's new signal inputs (input and model) for better reactivity and consistency. The changes are generally well-executed, migrating @Input() decorators to their signal equivalents and updating property access patterns accordingly. The use of model.required for two-way binding and input.required for one-way inputs is appropriate. However, a critical issue was identified in SiWebComponentWrapperComponent where the editable property was converted from an @Input() to a regular setter, which breaks its ability to receive input from parent components. This needs to be addressed to maintain functionality.

@chintankavathia chintankavathia force-pushed the refactor/dashboards/input/signals branch 2 times, most recently from 46a4f0a to 17587a2 Compare February 11, 2026 05:23
@chintankavathia chintankavathia force-pushed the refactor/dashboards/input/signals branch from 17587a2 to 40adda5 Compare February 11, 2026 06:33
@github-actions
Copy link

Code Coverage

@github-actions
Copy link

@chintankavathia chintankavathia marked this pull request as ready for review February 13, 2026 11:56
@chintankavathia chintankavathia requested review from a team as code owners February 13, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant