refactor(dashboards): use signal inputs internally#1487
refactor(dashboards): use signal inputs internally#1487chintankavathia wants to merge 1 commit intomainfrom
Conversation
chintankavathia
commented
Feb 10, 2026
- I confirm that this MR follows the contribution guidelines.
There was a problem hiding this comment.
Code Review
This pull request refactors several components to utilize Angular's new signal inputs (input and model) for better reactivity and consistency. The changes are generally well-executed, migrating @Input() decorators to their signal equivalents and updating property access patterns accordingly. The use of model.required for two-way binding and input.required for one-way inputs is appropriate. However, a critical issue was identified in SiWebComponentWrapperComponent where the editable property was converted from an @Input() to a regular setter, which breaks its ability to receive input from parent components. This needs to be addressed to maintain functionality.
...cts/dashboards-ng/src/components/web-component-wrapper/si-web-component-wrapper.component.ts
Show resolved
Hide resolved
46a4f0a to
17587a2
Compare
17587a2 to
40adda5
Compare
|
Documentation. Coverage Reports: |