Skip to content

docs(updating): add update guide#1485

Draft
spike-rabbit wants to merge 1 commit intomainfrom
docs/add-updating-guide
Draft

docs(updating): add update guide#1485
spike-rabbit wants to merge 1 commit intomainfrom
docs/add-updating-guide

Conversation

@spike-rabbit
Copy link
Member

Adds a general update guide for element.


Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a new update guide, which is a great addition. However, the structure of the guide could be confusing for users. The steps are not in a logical order, and it presents two different ng update commands, which could lead to errors. I've suggested a restructuring of the document to provide a clearer, step-by-step process for updating. The main points are to first update Angular, then Element, and to clarify what the automatic migration does versus what needs to be done manually.

@github-actions
Copy link

@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 530dc9c to 1f4c7f5 Compare February 10, 2026 09:48
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 1f4c7f5 to 773469d Compare February 10, 2026 11:05
Copy link
Member

@spliffone spliffone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we state which @simpl/brand version is necessary, since the consumer can only guess which major version to use

@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 773469d to 1359ceb Compare February 10, 2026 14:29
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 1359ceb to ba232e2 Compare February 10, 2026 14:43
@github-actions
Copy link

Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants