feat(landing-page): remove registration introduction text due to ux guidelines#1433
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively removes the 'Don't have an account?' introduction text as per the UX guidelines. The changes are consistently applied across the component's TypeScript, HTML template, API golden files, translation files, and Playwright snapshots. All modifications align with the stated objective of communicating with fewer words and appear to be correctly implemented without introducing any new issues.
|
Documentation. Coverage Reports: |
michael-smt
force-pushed
the
feat/drop-landing-page-register-intro
branch
2 times, most recently
from
6aa3aae to
eaa243e
Compare
dauriamarco
left a comment
dauriamarco
left a comment
There was a problem hiding this comment.
Just a small margin leftover, otherwise looks good 👍
dauriamarco
left a comment
dauriamarco
left a comment
There was a problem hiding this comment.
Just a small margin leftover, otherwise looks good 👍
michael-smt
force-pushed
the
feat/drop-landing-page-register-intro
branch
2 times, most recently
from
a5ecda7 to
60cb3c7
Compare
michael-smt
force-pushed
the
feat/drop-landing-page-register-intro
branch
2 times, most recently
from
644198e to
60bdf54
Compare
|
@Danisand One question...is this aligned with ix? We dont have fully aligned the visual design, but they still seem to have the "Don't have an account" phrase: 
|
Hi @panch1739 May be Element is faster to change it than iX 😄 |
|
@Danisand excelleeeent, thanks for clarifying. I'll update figma then also |
|
@michael-smt i think you can merge nooow |
michael-smt
force-pushed
the
feat/drop-landing-page-register-intro
branch
from
60bdf54 to
0c97ffc
Compare
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
- Please add a breaking change note for the removed property.
- Update the schematics to remove that input (in element-ng/schematics/data/symbol-removals.ts, no need to write tests)
michael-smt
force-pushed
the
feat/drop-landing-page-register-intro
branch
from
0c97ffc to
33db4f3
Compare
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Code is perfect 👍
Please align the breaking change with other similar ones we have:
This is what we have for tooltip:
The triggers input has been removed to align the behavior with accessibility guidelines.
Remove all usages. The tooltip will always be shown if the target element is focused or hovered.
The key pattern is The <input> has been removed to ...
michael-smt
force-pushed
the
feat/drop-landing-page-register-intro
branch
from
33db4f3 to
c51f291
Compare
spike-rabbit
force-pushed
the
feat/drop-landing-page-register-intro
branch
2 times, most recently
from
54bf3fb to
42692b1
Compare
…uidelines BREAKING CHANGE: The `registerNowIntroText` input has been removed to align with UX guidelines. Remove all usages.
spike-rabbit
force-pushed
the
feat/drop-landing-page-register-intro
branch
from
42692b1 to
ac3ceaa
Compare
|
|
5 participants
This removes the text "Don't have an account?" before the "Register now" to communicate with as few words as possible as requested by UX writing @Danisand.