Skip to content

docs: Add Microsoft Identity Provider#418

Merged
marcelomendoncasoares merged 3 commits intoserverpod:mainfrom
vfiruz97:docs/auth-microsoft
Feb 16, 2026
Merged

docs: Add Microsoft Identity Provider#418
marcelomendoncasoares merged 3 commits intoserverpod:mainfrom
vfiruz97:docs/auth-microsoft

Conversation

@vfiruz97
Copy link
Contributor

Hi @marcelomendoncasoares,
This PR adds a doc for serverpod/serverpod#4716. Please review when you have a chance.

@vfiruz97 vfiruz97 force-pushed the docs/auth-microsoft branch from 8ead32e to 1f42261 Compare February 16, 2026 05:07
Copy link
Collaborator

@marcelomendoncasoares marcelomendoncasoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the docs, @vfiruz97! A few suggestions for improvement.

@vfiruz97
Copy link
Contributor Author

Thanks @marcelomendoncasoares, for a quick feedback. The comments are addressed. Ready for another review.

Copy link
Collaborator

@marcelomendoncasoares marcelomendoncasoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@marcelomendoncasoares
Copy link
Collaborator

@vfiruz97 One thing that I just noticed: both this PR and #412 have the same numbering on the folder of the provider (both are adding 07-*). We could merge them and fix the order on other PR (if we wish to move Facebook to above GitHub, for example) or rearrange on the PRs so they land in order.

@vfiruz97
Copy link
Contributor Author

vfiruz97 commented Feb 16, 2026

Thanks @marcelomendoncasoares, appreciate your efforts. My suggestion, first merge this PR and then reorder in other PR.
But if we are good with the number 8 for the Facebook Idp, then simply I will change that to 8 and it will land well. But my suggestion, put the Facebook Idp up. Maybe in the number 4.

@marcelomendoncasoares
Copy link
Collaborator

Thanks @marcelomendoncasoares, appreciate your efforts. My suggestion, first merge this PR and then reorder in other PR. But if we are good with the number 8 for the Facebook Idp, then simply I will change that to 8 and it will land well. But my suggestion, put the Facebook Idp up. Maybe in the number 4.

Agree with the suggestion to move Facebook up to position 4. We should then also make the anonymous 1 (instead of 0 as it is now) in the same PR.

@marcelomendoncasoares marcelomendoncasoares merged commit c99f867 into serverpod:main Feb 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants