Fix wrong serialnumber in windows#190
Open
kaizhi-singtown wants to merge 3 commits intoserialport:mainfrom
Open
Fix wrong serialnumber in windows#190kaizhi-singtown wants to merge 3 commits intoserialport:mainfrom
kaizhi-singtown wants to merge 3 commits intoserialport:mainfrom
Conversation
Author
|
https://www.npmjs.com/package/@singtown/bindings-cpp A version is released for temporary use and will be deleted after merging. |
|
Hello, Many thanks by the way ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
The serialnumber of a composite device on Windows is not the same as that of a USB device.
This behavior is inconsistent with MacOS and Linux.
This behavior is also inconsistent with pyserial and qtserialport.
So we should change it.
The serialnumber we expect is the USB parent device. For example:
The pnpId is:
USB\VID_1209&PID_ABD1&MI_00\6&18DA7745&0&0000. The serialnumber contains the&character, which is incorrect. What we wanted was his fatherUSB\VID_1209&PID_ABD1\387132593131I refer to the code of qtserialport, https://github.com/qt/qtserialport/blob/dev/src/serialport/qserialportinfo_win.cpp#L470. Fixed this property.
I've also refactored other properties with cfgmgr32.h.
Related:
serialport/node-serialport#2726
serialport/node-serialport#1459