-
Notifications
You must be signed in to change notification settings - Fork 9
[COMP-1143]Missing HTTP Security Header #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
munishchouhan
wants to merge
3
commits into
master
Choose a base branch
from
COMP-1143-HTTP-Security-Header
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+425
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: munishchouhan <hrma017@gmail.com>
Member
Author
|
testing locally: |
Member
Author
|
Check all headers: |
Signed-off-by: munishchouhan <hrma017@gmail.com>
Member
Author
|
tested in dev: |
Member
Author
Member
Author
|
tested augmentation: |
Signed-off-by: munishchouhan <hrma017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements HTTP security headers for all Wave service responses to improve security posture and protect against common web vulnerabilities.
Changes
1. HTTP Security Headers Implementation
New Files Created:
src/main/groovy/io/seqera/wave/configuration/SecurityHeadersConfig.groovysrc/main/groovy/io/seqera/wave/filter/SecurityHeadersFilter.groovysrc/test/groovy/io/seqera/wave/filter/SecurityHeadersFilterTest.groovyModified Files:
src/main/groovy/io/seqera/wave/filter/FilterOrder.groovysrc/main/resources/application.ymlSummary:
Implemented a new HTTP filter that adds industry-standard security headers to all Wave service responses. The filter runs with the highest priority (-120) to ensure security headers are always present.
Security Headers Added:
Strict-Transport-Securitymax-age=31536000; includeSubDomainsX-Frame-OptionsDENYX-Content-Type-OptionsnosniffReferrer-Policystrict-origin-when-cross-originPermissions-Policycamera=(), microphone=(), geolocation=()Content-Security-Policydefault-src 'self'; frame-ancestors 'none'Architecture:
Key Features:
application.ymlwave.security.headers.enabled: falseOrderedinterface for proper filter execution orderConfiguration:
Default configuration added to
application.yml:Filter Order:
Security Benefits