-
Notifications
You must be signed in to change notification settings - Fork 9
docs: Add guide for bin scripts #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gwright99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments and thoughts. Good first pass but I feel that elaboration could be helpful for the average reader who doesn't yet have a full grasp on the inner workings of these various ecosystem components.
Tidying up PR - resolving agreed suggestions
…s/wave into docs-guide-bin-scripts
gwright99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to get PR unblocked and on understanding discussed items will be handled in separate document at some future point.
|
|
||
| When you enable Fusion or use the AWS Fargate executor, Wave bundles scripts from the project `bin/` directory into a container layer. This provides better performance but ties scripts to specific execution environments. Scripts are added to `/usr/local/bin/` in the container image, making them directly executable without path qualification. Remote `bin/` directory upload is disabled. | ||
|
|
||
| Modifying scripts in the project `bin/` directory modify the container fingerprint for all Wave containers in the workflow. See [Wave container fingerprinting](#wave-container-fingerprinting) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit too technical, i'd focus it will result in creating a modified container, and therefore invalidating the cache for previous runs
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This PR adds documentation for Wave's
binscript bundling behavior in Nextflow pipelines. This guide helps users understand which scripts get packaged into container images and how this affects container fingerprinting and caching.This PR is intentionally limited in scope to address a specific user pain point: understanding how Wave handles bin scripts from different directories (
${projectDir}/bin/vs.${moduleDir}/resources/usr/bin/) and when those scripts are bundled into container layers.The guide covers:
binscripts are bundledI've tried to keep the scope limited and focus on the bin behavior without going too deep. Not covered here: