This repository was archived by the owner on May 6, 2021. It is now read-only.
Implement smtp logging into /var/log/sendgrid.log and retry on failure#76
Open
leigh-ols wants to merge 2 commits intosendgrid:masterfrom
Open
Implement smtp logging into /var/log/sendgrid.log and retry on failure#76leigh-ols wants to merge 2 commits intosendgrid:masterfrom
leigh-ols wants to merge 2 commits intosendgrid:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per my comment in issue #71
Note that
/var/log/sendgrid.logwill need to be created and made http server writable by the user.The solution isn't perfect, as 3 consecutive failures will still result in emails disappearing into the ether. However it should minimize this and at least provide logs of failures for users. And so work as a useful stop gap until a proper mail queuing system can be implemented.