Skip to content

Add a threshold to the ContigencySimilarity metric #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fealho wants to merge 3 commits into
base: feature/column_pair_trends_threshold
Choose a base branch
from
Open

Add a threshold to the ContigencySimilarity metric #823

fealho wants to merge 3 commits into from
+98 −4

Conversation

@fealho
Copy link
Member

@fealho fealho commented Jan 15, 2026

CU-86b83kq9t, Resolve #817

@fealho fealho requested a review from a team as a code owner January 15, 2026 18:02
@fealho fealho requested review from gsheni and removed request for a team January 15, 2026 18:02
@sdv-team
Copy link
Contributor

sdv-team commented Jan 15, 2026

Task linked: CU-86b83kq9t SDMetrics - Add a threshold to the ContingencySimilarity metric #817

@fealho fealho changed the base branch from main to feature/column_pair_trends_threshold January 15, 2026 18:02
@codecov
Copy link

codecov bot commented Jan 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.74%. Comparing base (88c74d4) to head (3efa752).
⚠️ Report is 1 commits behind head on feature/column_pair_trends_threshold.

Additional details and impacted files 
@@                          Coverage Diff                          @@
##           feature/column_pair_trends_threshold     #823   +/-   ##
=====================================================================
  Coverage                                 95.73%   95.74%           
=====================================================================
  Files                                       117      117           
  Lines                                      4757     4767   +10     
=====================================================================
+ Hits                                       4554     4564   +10     
  Misses                                      203      203
Flag Coverage Δ
integration 80.93% <54.54%> (-0.07%) ⬇️
unit 84.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho requested a review from R-Palazzo January 15, 2026 18:24
gsheni
gsheni reviewed Jan 15, 2026
View reviewed changes
@fealho fealho requested a review from gsheni January 15, 2026 23:30
R-Palazzo
R-Palazzo reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fealho fealho requested a review from R-Palazzo January 16, 2026 15:33
@fealho fealho force-pushed the issue-817-threshold-contigency branch from 4f86f8d to 3efa752 Compare January 16, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsheni gsheni gsheni approved these changes

@R-Palazzo R-Palazzo Awaiting requested review from R-Palazzo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a threshold to the ContingencySimilarity metric

5 participants

@fealho @sdv-team @gsheni @R-Palazzo