Open
Conversation
Owner
|
Apart from my comments, this looks good! Hopefully the LSPProvider API is clear to implement things, I'm open to feedback. I agree, I think shutdown should probably be owned by LSPConnection, and the provider should just signal to it somehow. In the future maybe we add ShutdownProvider as a "default" provider in addition to InitializeProvider, and then listen for changes via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This is an attempt to implement shutdown requests.
This is useful for the stdio adapter that communicates with the nvim LSP client so that we can shut down the node process on nvim exit and thus freeing the open ports.
I did not implement this part of the spec:
We could perhaps set a flag in
LSPConnectionto signal when ashutdownrequest has been received, but I did not want to complicate the code until I get to know the code base a bit better.