Add mongodb e networks em docker-compose-dev.yml#309
Open
samuelveigarangel wants to merge 1 commit intoscieloorg:masterfrom
Open
Add mongodb e networks em docker-compose-dev.yml#309samuelveigarangel wants to merge 1 commit intoscieloorg:masterfrom
samuelveigarangel wants to merge 1 commit intoscieloorg:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR configures MongoDB connectivity for local development by adding a MongoDB service to the docker-compose setup and updating connection URIs in configuration templates.
- Adds a MongoDB container service to the docker-compose configuration
- Updates MongoDB connection URIs to include protocol and database name
- Establishes networking between services via a bridge network
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker-compose-dev.yml | Adds MongoDB service container, networking configuration, and updates the MONGODB_HOST environment variable to use the full MongoDB URI |
| development.ini-TEMPLATE | Updates mongo_uri to include HTTP protocol prefix and database name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # debugtoolbar.hosts = 127.0.0.1 ::1 | ||
|
|
||
| mongo_uri = 127.0.0.1:27017 | ||
| mongo_uri = http://127.0.0.1:27017/articlemeta |
There was a problem hiding this comment.
MongoDB URIs should use the 'mongodb://' protocol, not 'http://'. The http:// prefix is incorrect for MongoDB connections and will cause connection failures. Based on the code in controller.py line 257-258, the URI is parsed with urlparse and expects a proper MongoDB URI format.
Suggested change
| mongo_uri = http://127.0.0.1:27017/articlemeta | |
| mongo_uri = mongodb://127.0.0.1:27017/articlemeta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Onde a revisão poderia começar?
pelos commits
Como este poderia ser testado manualmente?
realizar o build do ambiente dev
Algum cenário de contexto que queira dar?
N/A
Screenshots
N/A
Quais são tickets relevantes?
N/A
Referências
N/A