Add missing dependencies for test_coordgen#117
Open
jyhpsycho wants to merge 1 commit intoschrodinger:masterfrom
Open
Add missing dependencies for test_coordgen#117jyhpsycho wants to merge 1 commit intoschrodinger:masterfrom
jyhpsycho wants to merge 1 commit intoschrodinger:masterfrom
Conversation
Author
|
It may be fixed after checking whether Boost::iostreams and zlib is needed or not to build on windows platform as like: |
ricrogz
reviewed
Jan 13, 2026
Collaborator
ricrogz
left a comment
ricrogz
left a comment
There was a problem hiding this comment.
Sorry for the (very) late review!
| find_package(ZLIB REQUIRED) | ||
|
|
||
| target_link_libraries(test_coordgen coordgen ${maeparser_LIBRARIES} ${boost_link_options} Boost::unit_test_framework Boost::filesystem) | ||
| target_link_libraries(test_coordgen coordgen ${maeparser_LIBRARIES} ${boost_link_options} Boost::unit_test_framework Boost::iostreams Boost::filesystem z) |
Collaborator
There was a problem hiding this comment.
According to https://cmake.org/cmake/help/latest/module/FindZLIB.html, it seems that the zlib link target should be specified as ZLIB::ZLIB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will fix #116