Fix architecture mapping for binary downloads #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix eza download to use correct architecture mapping (x86_64/aarch64 instead of amd64/arm64) - Fix delta download to include version in URL and use proper architecture mapping - Fix glow download to include version and use correct extraction path - Make setup.sh executable These fixes resolve download failures on different architectures by ensuring proper mapping between Docker ARCH and GitHub release naming conventions. Co-Authored-By: Warp <agent@warp.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes architecture mapping issues in the Docker base image that were causing download failures on different architectures.
Changes Made
Fixed Binary Downloads
amd64/arm64tox86_64/aarch64to match GitHub release namingx86_64/arm64), and fixed extraction pathFile Permissions
bin/setup.shexecutable (mode change from 644 to 755)Problem Solved
The Dockerfile.base was failing to download binaries on different architectures due to mismatched architecture naming conventions:
dpkg --print-architecturereturnsamd64/arm64x86_64/aarch64for many toolsTesting
✅ Docker build tested successfully on the current system
✅ All binary downloads now use correct architecture mapping
✅ Version fetching ensures compatibility with latest releases
Co-Authored-By: Warp agent@warp.dev