Skip to content

Conversation

@mscasso-scanoss
Copy link
Contributor

@mscasso-scanoss mscasso-scanoss commented Jan 19, 2026

…ng enabled config

Summary by CodeRabbit

Version 5.4.21

  • Bug Fixes
    • Fixed ranking behavior default initialization
    • Improved debug mode flag handling
    • Updated high-accuracy mode behavior with flag combinations

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

SCANOSS version updated to 5.4.21. Default scan ranking behavior disabled by changing initialization from 0 to -1. High-accuracy mode flag automatically applied when combining certain options removed. Debug mode argument handling simplified with flag propagation logic eliminated.

Changes

Cohort / File(s) Summary
Version Update
inc/scanoss.h
SCANOSS_VERSION macro incremented from "5.4.20" to "5.4.21"
Main Configuration Changes
src/main.c
scan_ranking_threshold default changed from 0 to -1, disabling ranking-based acceptance by default; removed automatic ENABLE_HIGH_ACCURACY flag when combining -s and -a options; simplified debug mode handling by removing engine flag propagation logic

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A version hops along so spry,
Ranking thresholds wave goodbye,
High-accuracy flags take flight,
Debug modes simplified, crisp and light!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to fix a 'matchmap size' bug during SBOM ingestion, but the actual changes involve version bumping, disabling ranking by default, removing high-accuracy mode logic, and simplifying debug mode handling - none of which relate to matchmap size. Update the title to accurately reflect the primary changes, such as: 'Disable ranking by default and remove high-accuracy mode for combined -s/-a flags' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@scanoss-qg scanoss-qg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants