feat: Добавлен сахар: дополнительные методы подписки на команды сценария#256
Open
evgeniysemin wants to merge 1 commit intomainfrom
Open
feat: Добавлен сахар: дополнительные методы подписки на команды сценария#256evgeniysemin wants to merge 1 commit intomainfrom
evgeniysemin wants to merge 1 commit intomainfrom
Conversation
sasha-tlt
reviewed
Jan 28, 2022
sasha-tlt
reviewed
Feb 3, 2022
evgeniysemin
force-pushed
the
issues/247-subscribeToCommand
branch
from
0a01573 to
74036ea
Compare
sasha-tlt
reviewed
Feb 14, 2022
sasha-tlt
reviewed
Feb 14, 2022
sasha-tlt
reviewed
Feb 14, 2022
evgeniysemin
force-pushed
the
issues/247-subscribeToCommand
branch
from
74036ea to
fe890d3
Compare
evgeniysemin
changed the title
evgeniysemin
changed the title
evgeniysemin
force-pushed
the
issues/247-subscribeToCommand
branch
2 times, most recently
from
004638d to
8374a0c
Compare
…ария, ассистента, ошибки
evgeniysemin
force-pushed
the
issues/247-subscribeToCommand
branch
from
8374a0c to
2b0a93d
Compare
sasha-tlt
reviewed
Feb 21, 2022
| } | ||
| }); | ||
| }, | ||
| onSmartAppError: (subscriber: (smartAppError: AssistantSmartAppError['smart_app_error']) => void) => { |
Contributor
There was a problem hiding this comment.
нужно убрать, дублирует on('error')
sasha-tlt
reviewed
Feb 21, 2022
| } | ||
| }); | ||
| }, | ||
| onAssistantCommand: ( |
Contributor
There was a problem hiding this comment.
попробовать сделать один метод для подписки на команды и smart_app_data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
4.17.0--canary.256.004c305de8dd0429be86cdeb3b7d18e7a7e5457e.0✨ Test out this PR locally via:
npm install @sberdevices/assistant-client@4.17.0--canary.256.004c305de8dd0429be86cdeb3b7d18e7a7e5457e.0 # or yarn add @sberdevices/assistant-client@4.17.0--canary.256.004c305de8dd0429be86cdeb3b7d18e7a7e5457e.0