Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
214 commits
Select commit Hold shift + click to select a range
5adbf5c
djl -- add average calo v2 as an option for flow
Dec 18, 2025
35a6b31
add return if LoadCalibrations failed
Dec 18, 2025
2e9ccc7
djl -- array to vector
Dec 18, 2025
ce0d3af
djl -- change error handling to exit and not check for nullptr
Dec 19, 2025
6ddbed5
Add matching flag to evaluation.
hupereir Apr 14, 2025
3394890
Merge pull request #4089 from hupereir/micromegas_pool_evaluation_update
osbornjd Jan 6, 2026
67423a3
clang-format
osbornjd Jan 6, 2026
014600a
adding quality flag to total energy calc and correlations
Jan 6, 2026
2a654bd
clang-tidy for PHGenFit
pinkenburg Jan 6, 2026
3e94777
appeasing the rabbit
Jan 6, 2026
667a5cc
clang-tidy for mvtx
pinkenburg Jan 6, 2026
45a8c5b
clang-tidy for tpc
pinkenburg Jan 6, 2026
1ba5701
Added sample to hit key. This will allow to use timed hits.
hupereir Dec 16, 2025
815ceef
Add sample to hit key
hupereir Dec 16, 2025
d0a251d
fixed comments
hupereir Dec 16, 2025
0f8adaa
Sort hits by strip number
hupereir Dec 16, 2025
49ff81c
default max sample is 1024 (full range)
hupereir Dec 16, 2025
0c648ef
implemented min and max sample range for selecting clusters.
hupereir Dec 16, 2025
9e7cf18
fix bad bug found by coderabbit
pinkenburg Jan 7, 2026
514cbf6
better performace according to code rabbit
pinkenburg Jan 7, 2026
5c1fb73
make coderabbit happy
pinkenburg Jan 7, 2026
3f30522
fix botched formatting
pinkenburg Jan 7, 2026
0785178
clang-tidy
osbornjd Jan 7, 2026
e06322f
Update offline/packages/micromegas/MicromegasDefs.cc
hupereir Jan 7, 2026
89660ef
Update offline/packages/micromegas/MicromegasDefs.cc
hupereir Jan 7, 2026
ab568eb
Merge pull request #4091 from bseidlit/master
bseidlit Jan 7, 2026
7e9afac
Merge pull request #4090 from osbornjd/clang-format
osbornjd Jan 7, 2026
2f32421
handle max between a double and an int correctly with rounding
pinkenburg Jan 7, 2026
3fe3cd3
CD: New version of silicon pooling
cdean-github Jan 7, 2026
774e982
Merge branch 'master' of github.com:sPHENIX-Collaboration/coresoftwar…
cdean-github Jan 7, 2026
34e66d1
Merge pull request #4092 from pinkenburg/clang-tidy-57
pinkenburg Jan 7, 2026
c6b077c
- removed static as per clang-tidy
hupereir Jan 7, 2026
f5a6ec8
clang-tidy
hupereir Jan 7, 2026
af55b25
add e22 showershape
Shuonli Jan 8, 2026
8d61916
more clang-tidy
hupereir Jan 8, 2026
3a535f0
📝 Add docstrings to `photonclass`
coderabbitai[bot] Jan 8, 2026
16716a5
Merge pull request #4095 from Shuonli/photonclass
pinkenburg Jan 8, 2026
83bb8a6
Merge pull request #4096 from sPHENIX-Collaboration/coderabbitai/docs…
pinkenburg Jan 8, 2026
5ec7de1
Merge pull request #4093 from hupereir/micromegas-decoding-update
osbornjd Jan 8, 2026
15b6eed
Merge pull request #4094 from cdean-github/KFParticle
osbornjd Jan 8, 2026
66f7822
Revert "📝 Add docstrings to `photonclass`"
pinkenburg Jan 8, 2026
ed4562e
Merge pull request #4097 from sPHENIX-Collaboration/revert-4096-coder…
pinkenburg Jan 8, 2026
7e92dc7
Fix bugs in CaloValid to select correct MB + 10 cm trigger
emclaughlin2 Jan 8, 2026
a573ec3
make setters functional
osbornjd Jan 8, 2026
fcb6312
Fix Gl1Packet ID type from string to integer
pinkenburg Jan 8, 2026
c3eb9c5
Merge pull request #4098 from emclaughlin2/master
pinkenburg Jan 8, 2026
36cd47a
adding more of the skeleton structure
silas-gross Jan 9, 2026
b4b37c2
Merge pull request #4099 from osbornjd/cluster_map_name
osbornjd Jan 9, 2026
c361551
Nearly done, just need to dust around the edges
silas-gross Jan 10, 2026
23ef520
Bare minimum working version of HepMC particle trigger. Requires inpu…
silas-gross Jan 10, 2026
498393a
Fixed to adress issues found by CodeRabbit
silas-gross Jan 10, 2026
e18445b
a few more code rabbit fixes
silas-gross Jan 10, 2026
ebbee62
Is this the last one CodeRabbit???
silas-gross Jan 10, 2026
3d0a2e4
fixed pdgid lookup issue
silas-gross Jan 10, 2026
5628bd2
code rabbit found a bug in the return value
Jan 10, 2026
c7adbfd
Merge branch 'sPHENIX-Collaboration:master' into fixed_calo_v2
danjlis Jan 10, 2026
62c7a10
add hook to run shell script before opening an input file
pinkenburg Jan 10, 2026
5d5a980
do not save cdb files if they are empty (do not exist)
pinkenburg Jan 10, 2026
fd44486
cleanup, modernize
pinkenburg Jan 10, 2026
3505cae
Merge pull request #4069 from danjlis/fixed_calo_v2
pinkenburg Jan 10, 2026
51336ae
fix clang-tidy for HepMCTrigger
pinkenburg Jan 10, 2026
b0df38c
fix typo in initialiation
pinkenburg Jan 11, 2026
ee08eb4
Merge pull request #4101 from pinkenburg/no-saving-of-empty-cdbfiles
pinkenburg Jan 11, 2026
2b02a79
Merge pull request #4100 from silas-gross/PHHerwig
pinkenburg Jan 11, 2026
11cb711
fixed crash when calopackets are empty
mchiu-bnl Jan 12, 2026
f63acd8
Merge branch 'master' into run-before-opening
pinkenburg Jan 12, 2026
47ab938
call script before opening
pinkenburg Jan 12, 2026
7eb599f
make rabbit happy
pinkenburg Jan 12, 2026
5d10d3e
fix clang-tidy for InputFileHandler
pinkenburg Jan 13, 2026
f9373cf
Fixed issues around the edges of Jet, set better default behavior of …
silas-gross Jan 13, 2026
90a2f62
Fixed issues around the edges of Jet, set better default behavior of …
silas-gross Jan 13, 2026
7b52f16
Merge branch 'sPHENIX-Collaboration:master' into PHHerwig
silas-gross Jan 13, 2026
ce2f8a3
Merge pull request #4103 from pinkenburg/run-before-opening
pinkenburg Jan 13, 2026
bcc0827
Merge pull request #4102 from mchiu-bnl/mbd
pinkenburg Jan 13, 2026
5b6afda
add type 37: hijing O+O 0-15fm
pinkenburg Jan 14, 2026
0f402d4
Merge pull request #4107 from pinkenburg/filelist-add-OO
pinkenburg Jan 14, 2026
85e50bb
clang-tidy for HepMCJetTrigger
pinkenburg Jan 14, 2026
e3fffce
Fixed bug in logic for using existing parameter sets
adfrawley Jan 14, 2026
2cbb506
Merge branch 'master' of https://github.com/sPHENIX-Collaboration/cor…
adfrawley Jan 14, 2026
d7d58e1
this change fixes the tpc drift velocity being set to zero
pinkenburg Jan 15, 2026
63e54e6
Merge pull request #4111 from pinkenburg/fix-tpc-drift-pythia8
pinkenburg Jan 15, 2026
04e747f
📝 Add docstrings to `fix-tpc-drift-pythia8`
coderabbitai[bot] Jan 15, 2026
53eb479
Merge pull request #4104 from silas-gross/PHHerwig
pinkenburg Jan 15, 2026
1fe3891
Fix missing newline at end of PHPythia8.cc
pinkenburg Jan 15, 2026
bfcf35d
Merge pull request #4112 from sPHENIX-Collaboration/coderabbitai/docs…
pinkenburg Jan 15, 2026
69de5bb
do not read flow angles if flow afterburner was not run
pinkenburg Jan 15, 2026
3d19299
return NAN if flow psi vector is empty
pinkenburg Jan 15, 2026
64138d4
Merge pull request #4113 from pinkenburg/no-flow-afterburner
pinkenburg Jan 15, 2026
b209d85
dEdxFitter initial commit
Jan 15, 2026
2525b3b
restor cout state after every call to pythia8
pinkenburg Jan 15, 2026
bd1ae49
restore cout state after each call to subsystem code
pinkenburg Jan 15, 2026
04d5376
resotre cout before sending abortrun
pinkenburg Jan 15, 2026
7b60428
Merge pull request #4109 from adfrawley/new_tpc_transforms
osbornjd Jan 16, 2026
99b5ed4
abort events with any mbd packet empty
mchiu-bnl Jan 16, 2026
8cbb176
coderabbit and clang-tidy fixes
Jan 16, 2026
bea795c
Merge pull request #4115 from pinkenburg/preserve-cout
pinkenburg Jan 16, 2026
774ed82
Merge pull request #4116 from mchiu-bnl/mbd
pinkenburg Jan 16, 2026
d1152d0
New QA module to make cluster-state residual plots
rosstom2232 Jan 17, 2026
6c11c5d
clang-tidy
osbornjd Jan 17, 2026
7030fb8
Merge pull request #4118 from rosstom2232/TPOTQA
osbornjd Jan 17, 2026
ec8e8a6
CD: Stop KFP from aborting events
cdean-github Jan 17, 2026
68b618f
add flag to prune all seeds
osbornjd Jan 17, 2026
c12d8ae
adding more calo embedding tools
Jan 17, 2026
f4e898f
adding makefile update
Jan 17, 2026
61ecab4
extra feat in triggerskimmer
Jan 17, 2026
4da13b0
Merge pull request #4119 from cdean-github/KFParticle
osbornjd Jan 18, 2026
ad7235e
clang-tidy
osbornjd Jan 18, 2026
27c0ce0
Merge pull request #4120 from osbornjd/cluster_pruner
osbornjd Jan 18, 2026
2963c36
use short int for vertex beam crossing
hrjheng Jan 18, 2026
6242823
add const ref
Jan 18, 2026
c6d1c91
Merge pull request #4121 from bseidlit/embed
bseidlit Jan 19, 2026
2601ddc
minor fix for event skipping
Jan 19, 2026
6caf8c9
Add workflow to fix EOF newlines in docstring PRs
blackcathj Jan 19, 2026
57a9dd2
changing ADC threshold for time calib
Jan 19, 2026
d50b1e1
📝 Add docstrings to `embed`
coderabbitai[bot] Jan 19, 2026
0e1aa45
Fix missing final newline in docstring PR
github-actions[bot] Jan 19, 2026
88933ca
Merge pull request #4125 from bseidlit/embed
bseidlit Jan 20, 2026
990e9d7
Merge pull request #4123 from pjwinnetou/master
pinkenburg Jan 20, 2026
147009b
add api to reject clusters on edge, reject clusters with edge>0
osbornjd Jan 20, 2026
febf1e2
Add type 38: 60GeV jets
pinkenburg Jan 20, 2026
b7bf6cd
Merge pull request #4129 from pinkenburg/add-60GeV-jets
pinkenburg Jan 20, 2026
6ce581e
clang-tidy and clang-format
osbornjd Jan 20, 2026
435537f
clang-tidy
osbornjd Jan 20, 2026
7c32019
take first and last cluster in charge sign determination
osbornjd Jan 20, 2026
300975c
moved the ngood nevts to public variables to allow for better usage
silas-gross Jan 20, 2026
2f01ab5
add functional fit
Shuonli Jan 20, 2026
5334735
Update offline/packages/CaloReco/CaloWaveformFitting.cc
Shuonli Jan 21, 2026
76b38ec
Merge pull request #4128 from osbornjd/reject_cluster_edges
osbornjd Jan 21, 2026
0296552
clang-tidy fixes
Jan 21, 2026
db1ed97
change default
Shuonli Jan 21, 2026
0d8b5fc
clang tidy
Shuonli Jan 21, 2026
ab0c1db
Merge pull request #4130 from osbornjd/improve_charge_sign
osbornjd Jan 21, 2026
47d0f38
make default consistant
Shuonli Jan 21, 2026
74e4533
Allowed for access to n_good and n_evts while keeping the variables p…
silas-gross Jan 21, 2026
f704495
Merge pull request #4131 from Shuonli/function_fit
pinkenburg Jan 21, 2026
b56ed66
event counter was in the wrong place
silas-gross Jan 21, 2026
9a19bb9
cppcheck fix
Jan 22, 2026
d9bda1e
fix pileup handling for oo in CreateFileList.pl
pinkenburg Jan 22, 2026
747eba0
Merge pull request #4133 from pinkenburg/oo-pileup
pinkenburg Jan 22, 2026
45f47ca
fix typo
pinkenburg Jan 22, 2026
561e967
Merge pull request #4134 from pinkenburg/fix-oo-pileup
pinkenburg Jan 22, 2026
18c5a2c
Merge branch 'sPHENIX-Collaboration:master' into PHHerwig
silas-gross Jan 22, 2026
0efe275
Several updates: Add clusterlayer to clustertree, calculate cluster p…
adfrawley Jan 22, 2026
9ec298f
Merge branch 'master' of https://github.com/sPHENIX-Collaboration/cor…
adfrawley Jan 22, 2026
3fa48da
DetermineTowerBackground - Add Psi2 Safety Check
Steepspace Jan 22, 2026
8912872
Merge pull request #4114 from petermic/dedxfitter
osbornjd Jan 23, 2026
80be7af
Bug fix.
adfrawley Jan 23, 2026
79a1639
Adds local PID parametrization file option to KFParticle_sPHENIX
Jan 23, 2026
f810048
Merge pull request #4136 from Steepspace/jetbackground-fix
pinkenburg Jan 24, 2026
8b6df96
Merge pull request #4132 from silas-gross/PHHerwig
pinkenburg Jan 24, 2026
dc058d6
key the vertex using both position and process id
Shuonli Jan 24, 2026
4ed3e0a
Merge branch 'sPHENIX-Collaboration:master' into function_fit
Shuonli Jan 24, 2026
4a03dcf
this package uses openmp, clang needs -fopenmp to link this
pinkenburg Jan 24, 2026
4a20dee
Merge pull request #4139 from pinkenburg/fix-clang
pinkenburg Jan 25, 2026
66a0623
trigger jenkins
osbornjd Jan 26, 2026
8213894
empty commit to trigger checks
Shuonli Jan 26, 2026
fdfe0be
Fixed library dependency (libtrack_reco -> libtrackbase_historic).
hupereir Jan 26, 2026
a95f3ef
modify seed merger to just remove duplicates
osbornjd Jan 26, 2026
3d56c18
clang tidy and format
osbornjd Jan 26, 2026
7ef17b3
📝 Add docstrings to `silicon_duplicate_removal`
coderabbitai[bot] Jan 27, 2026
e53dbd4
Fix missing final newline in docstring PR
github-actions[bot] Jan 27, 2026
ba6123d
Merge pull request #4141 from osbornjd/silicon_duplicate_removal
osbornjd Jan 27, 2026
c38e200
trigger jenkins
osbornjd Jan 27, 2026
9d25f5e
trigger jenkins
osbornjd Jan 27, 2026
5e38c10
trigger jenkins
osbornjd Jan 27, 2026
382455a
added mbd_status calib, overlapping waveforms (pileup) fit
mchiu-bnl Jan 27, 2026
d7dc7f8
rabbit fixes
mchiu-bnl Jan 27, 2026
4927696
rabbit fixes part deux, plus added fiteval
mchiu-bnl Jan 27, 2026
5c8076f
Fix missing final newline in docstring PR
github-actions[bot] Jan 27, 2026
3c3acc7
Merge branch 'master' into coderabbitai/docstrings/4a20dee
osbornjd Jan 27, 2026
924e18e
Fix missing final newline in docstring PR
github-actions[bot] Jan 27, 2026
f20ff92
Merge pull request #4142 from sPHENIX-Collaboration/coderabbitai/docs…
osbornjd Jan 27, 2026
f190da5
Merge pull request #4138 from Shuonli/function_fit
pinkenburg Jan 27, 2026
34a2897
📝 Add docstrings to `function_fit`
coderabbitai[bot] Jan 27, 2026
a9adfb1
Fix missing final newline in docstring PR
github-actions[bot] Jan 27, 2026
f493c6e
aborts run if calibration is missing for doing fits
mchiu-bnl Jan 28, 2026
349b8f6
Merge pull request #4140 from hupereir/fix_dedx_dependencies
osbornjd Jan 28, 2026
8bc0f1f
make function const
osbornjd Jan 28, 2026
10b3949
Merge pull request #4144 from sPHENIX-Collaboration/coderabbitai/docs…
pinkenburg Jan 28, 2026
89fe92c
Merge pull request #4126 from sPHENIX-Collaboration/coderabbitai/docs…
pinkenburg Jan 28, 2026
47036fb
Merge branch 'sPHENIX-Collaboration:master' into SvtxVertex_fix
hrjheng Jan 28, 2026
8fb707e
Revert "use short int for vertex beam crossing"
hrjheng Jan 28, 2026
71c8448
Coderabbit was correct, bug fix.
adfrawley Jan 28, 2026
2865d6b
Merge branch 'master' of https://github.com/sPHENIX-Collaboration/cor…
adfrawley Jan 28, 2026
344e32c
Merge branch 'new_tpc_transforms' of github.com:adfrawley/coresoftwar…
adfrawley Jan 28, 2026
918880d
CaloValid - O+O Update
Steepspace Jan 28, 2026
3c966d3
New version of SvtxVertex, MbdVertex, and GlovalVertex to use short i…
hrjheng Jan 28, 2026
4814fd2
remove need for status calib - defaults to all good
mchiu-bnl Jan 29, 2026
8fdaffe
Merge pull request #4143 from mchiu-bnl/mbd
pinkenburg Jan 29, 2026
d87e715
update to v3
hrjheng Jan 29, 2026
373f714
Merge pull request #4145 from Steepspace/CaloValid-OO-update
pinkenburg Jan 29, 2026
6946cba
📝 Add docstrings to `CaloValid-OO-update`
coderabbitai[bot] Jan 29, 2026
72f7c46
Fix missing final newline in docstring PR
github-actions[bot] Jan 29, 2026
6cd5ea7
Merge pull request #4146 from sPHENIX-Collaboration/coderabbitai/docs…
pinkenburg Jan 29, 2026
b7268de
Merge pull request #4122 from hrjheng/SvtxVertex_fix
pinkenburg Jan 29, 2026
9bb1cc1
Increased Cluster State Residual QA capabilites
rosstom2232 Jan 30, 2026
3e0b412
Merge branch 'master' of github.com:rosstom2232/coresoftware into TPOTQA
rosstom2232 Jan 30, 2026
3ab3316
do not abort for missing trms calib
pinkenburg Jan 30, 2026
802d4d2
Merge pull request #4148 from pinkenburg/mbd-hotfix
pinkenburg Jan 30, 2026
9694b18
Merge pull request #4135 from adfrawley/new_tpc_transforms
osbornjd Jan 30, 2026
5a30bf1
doesn't try to download sampmax calibs etc for sims
mchiu-bnl Jan 30, 2026
fde222e
fixed rabbit error
mchiu-bnl Jan 30, 2026
18821af
Fixing clang tidy issue and TH2 typo
rosstom2232 Jan 31, 2026
30fc305
Merge pull request #4149 from mchiu-bnl/mbd
pinkenburg Jan 31, 2026
be6271b
undo checks for existence of calibs - this breaks ability to calc the…
mchiu-bnl Feb 1, 2026
278cf73
undo checks for existence of calibs - this breaks ability to calc the…
mchiu-bnl Feb 1, 2026
d780913
Merge pull request #4151 from mchiu-bnl/mbd
pinkenburg Feb 1, 2026
09d7e63
expand crossing range
osbornjd Feb 2, 2026
479fedc
TrkrNtuplizer hit analysis and PID fixes
Feb 2, 2026
735cf53
Merge branch 'master' of http://github.com/sphenix-collaboration/core…
Feb 2, 2026
8b00901
reverse commit mixup
Feb 2, 2026
e0f89f1
Merge pull request #4152 from osbornjd/crossing_plot
osbornjd Feb 2, 2026
d5aeeca
Merge pull request #4147 from rosstom2232/TPOTQA
osbornjd Feb 2, 2026
04d7a96
Merge pull request #4153 from petermic/trkrntuplizer_fix
osbornjd Feb 2, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions .github/workflows/fix-eof-newline-coderabbit-docstrings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
name: Fix missing final newline (CodeRabbit docstring PRs)

on:
pull_request_target:
types: [opened, synchronize, reopened]

permissions:
contents: write
pull-requests: read

jobs:
fix_eof_newline:
runs-on: ubuntu-latest
steps:
- name: Guard - only CodeRabbit docstring PRs from same repo
id: guard
shell: bash
run: |
set -euo pipefail

AUTHOR='${{ github.event.pull_request.user.login }}'
BASE_REPO='${{ github.event.pull_request.base.repo.full_name }}'
HEAD_REPO='${{ github.event.pull_request.head.repo.full_name }}'
TITLE='${{ github.event.pull_request.title }}'

if [[ "$AUTHOR" != "coderabbitai[bot]" ]]; then
echo "run=false" >> "$GITHUB_OUTPUT"
exit 0
fi

# Safety: only push to branches within the same repo
if [[ "$BASE_REPO" != "$HEAD_REPO" ]]; then
echo "run=false" >> "$GITHUB_OUTPUT"
exit 0
fi

# only run for docstring PRs
if ! echo "$TITLE" | grep -qi "docstring"; then
echo "run=false" >> "$GITHUB_OUTPUT"
exit 0
fi

echo "run=true" >> "$GITHUB_OUTPUT"

- name: Checkout PR head
if: steps.guard.outputs.run == 'true'
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
fetch-depth: 0

- name: Append final newline when missing (changed files only)
if: steps.guard.outputs.run == 'true'
shell: bash
run: |
set -euo pipefail

BASE_SHA="${{ github.event.pull_request.base.sha }}"
HEAD_SHA="${{ github.event.pull_request.head.sha }}"

files=$(git diff --name-only "$BASE_SHA" "$HEAD_SHA" -- \
'*.C' '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' || true)

if [[ -z "${files}" ]]; then
echo "No relevant files changed."
exit 0
fi

changed=0
for f in $files; do
[[ -f "$f" ]] || continue

# For non-empty files: ensure last byte is '\n'
if [[ -s "$f" ]]; then
last_byte="$(tail -c 1 "$f" || true)"
if [[ "$last_byte" != $'\n' ]]; then
printf '\n' >> "$f"
echo "Fixed EOF newline: $f"
changed=1
fi
fi
done

if [[ "$changed" -eq 0 ]]; then
echo "All files already end with a newline."
exit 0
fi

git status --porcelain
git add -A

git config user.name "github-actions[bot]"
git config user.email "github-actions[bot]@users.noreply.github.com"

git commit -m "Fix missing final newline in docstring PR"

- name: Push fix commit back to PR branch
if: steps.guard.outputs.run == 'true'
shell: bash
run: |
set -euo pipefail
# If no commit was created, pushing will fail; so only push if HEAD is ahead.
if git rev-parse HEAD~1 >/dev/null 2>&1; then
git push origin "HEAD:${{ github.event.pull_request.head.ref }}"
fi
Loading