Add ConstLowerBounded/ConstUpperBounded/ConstBounded traits, impls, and tests#351
Open
linclelinkpart5 wants to merge 2 commits intorust-num:masterfrom
Open
Add ConstLowerBounded/ConstUpperBounded/ConstBounded traits, impls, and tests#351linclelinkpart5 wants to merge 2 commits intorust-num:masterfrom
ConstLowerBounded/ConstUpperBounded/ConstBounded traits, impls, and tests#351linclelinkpart5 wants to merge 2 commits intorust-num:masterfrom
Conversation
|
Hope you don't mind a nitpicking suggestion, the macro can be simplified: macro_rules! const_bounded_impl {
($t:ty) => {
impl ConstLowerBounded for $t {
const MIN: Self = Self::MIN;
}
impl ConstUpperBounded for $t {
const MAX: Self = Self::MAX;
}
};
}
const_bounded_impl!(usize);
const_bounded_impl!(u8);
const_bounded_impl!(u16);
const_bounded_impl!(u32);
const_bounded_impl!(u64);
const_bounded_impl!(u128);
const_bounded_impl!(isize);
const_bounded_impl!(i8);
const_bounded_impl!(i16);
const_bounded_impl!(i32);
const_bounded_impl!(i64);
const_bounded_impl!(i128);
const_bounded_impl!(f32);
const_bounded_impl!(f64); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality as requested in #252.
This is done by adding
ConstLowerBoundedandConstUpperBoundedtraits, with associated costs ofconst MIN: Selfandconst MAX: Self, respectively. In addition, I also includedConstBoundedas a supertrait, and impl'd it for all types that implementConstLowerBounded + ConstUpperBounded:These traits have been implemented for all primitive types that the existing
Boundedtraits have been impl'd for.