Implement NaN propagating minmax with TotalOrder and FloatCore#323
Implement NaN propagating minmax with TotalOrder and FloatCore#323jdh8 wants to merge 2 commits intorust-num:masterfrom
Conversation
|
Adding Thematically though, I would expect them to be called |
|
No, they do not fully follow the rules of The nightly builtin |
|
I see -- I wasn't aware of those unstable methods. However, the tracking issue still has a number of unresolved questions, and I'd rather wait to see that stabilized before we try to match their name and behavior. Even then, a breaking change is still a problem, but you could put |
…a breaking change
Given the IEEE total-ordering predicate and
.is_nan(), we can implement NaN propagating minmax, cf.f32::maximum.I'm not sure if using
.is_nan()withtrait TotalOrder: FloatCoreis the best idea, but I can't think of a better one for now.