Small code comment correction (ARM_CONTROL register bit numbers) #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think we should wait, until the PR has been handled in the raspberrypi/tools project. They should now it best. |
Owner
|
There is no further reaction in raspberrypi/tools and I want to complete this now. I think we can trust the documentation, so I merged your correction. Thank you! |
petemoore
added a commit
to petemoore/circle
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor doc fix. I've created an upstream PR too: raspberrypi/tools#134
See https://datasheets.raspberrypi.com/bcm2711/bcm2711-peripherals.pdf page 93
The assumption here is that the PDF is correct and the code comments are wrong, but I guess it could be the other way around...