Additional safeguards for re-renders and error types#88
Open
dylanjustice wants to merge 1 commit intorsm-hcd:mainfrom
Open
Additional safeguards for re-renders and error types#88dylanjustice wants to merge 1 commit intorsm-hcd:mainfrom
dylanjustice wants to merge 1 commit intorsm-hcd:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 17 17
Lines 295 295
Branches 31 31
=======================================
Hits 281 281
Misses 13 13
Partials 1 1
Continue to review full report at Codecov.
|
brandongregoryscott
approved these changes
Jun 22, 2021
Contributor
brandongregoryscott
left a comment
There was a problem hiding this comment.
Would be nice to add a few tests to cover this behavior if you have the time 👍 But good to get this updated, either way.
myty
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#67 Add additional safeguards
Covers errors that may not be strings or an instance of a ResultRecord.
Potentially prevent an unnecessary re-render by setting the state to the previous value when empty, rather than instantiating a new array.