Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 17 17
Lines 295 295
Branches 31 31
=======================================
Hits 281 281
Misses 13 13
Partials 1 1
Continue to review full report at Codecov.
|
3dc6e9c to
daaa22d
Compare
daaa22d to
7a66e0c
Compare
jhugs
approved these changes
Jun 22, 2021
brandongregoryscott
suggested changes
Jun 22, 2021
Contributor
brandongregoryscott
left a comment
There was a problem hiding this comment.
Left some comments for cleanup, but looks good overall 👍
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
src/providers/network-connection/network-connection-provider.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
I forgot to mention - all of these will need to be exported from |
brandongregoryscott
approved these changes
Jun 22, 2021
brandongregoryscott
suggested changes
Jun 24, 2021
Contributor
brandongregoryscott
left a comment
There was a problem hiding this comment.
Just some minor changes w/ the factory setup - thanks again for getting this ported over 👍
brandongregoryscott
approved these changes
Jun 25, 2021
jhugs
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.