Use individual board makefiles#94
Open
GrantM11235 wants to merge 5 commits intorogerclarkmelbourne:masterfrom
Open
Use individual board makefiles#94GrantM11235 wants to merge 5 commits intorogerclarkmelbourne:masterfrom
GrantM11235 wants to merge 5 commits intorogerclarkmelbourne:masterfrom
Conversation
Owner
|
Thanks I'll try it on my PC |
|
This seems a sensible improvement; is there anything blocking its merging? TIA! |
Contributor
Author
|
I just checked this again, it still produces identical binaries. In my opinion this is ready to be merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make <board>createsbootloader_only_binaries/<board>.binby includingboards/<board>.mk.make allrunsmake <board>for every board in theboards/.This dramatically simplifies the makefile and makes it much easier to maintain and add new boards.
This pull request (and each individual commit) should produce binaries that are identical to the master branch: