-
Notifications
You must be signed in to change notification settings - Fork 11
[Win32] Add win32 compatibility. #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| +24 −4 | boost.cmake | |
| +0 −4 | header.cmake | |
| +39 −8 | python.cmake | |
| +180 −0 | python/FindPythonInterp.cmake | |
| +310 −0 | python/FindPythonLibs.cmake |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ MACRO(IPOPT_PLUGIN NAME) | |
| INSTALL(TARGETS roboptim-core-plugin-${NAME} | ||
| DESTINATION ${PLUGINDIR}) | ||
| PKG_CONFIG_USE_DEPENDENCY(roboptim-core-plugin-${NAME} ipopt) | ||
| PKG_CONFIG_USE_COMPILE_DEPENDENCY(roboptim-core-plugin-${NAME} roboptim-core) | ||
| PKG_CONFIG_USE_DEPENDENCY(roboptim-core-plugin-${NAME} roboptim-core) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Except plugins do not need to be linked with roboptim-core. What was the error?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without the link, there is a lot of missing symbols :
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those symbols should come from the main library/executable that loads the plugin, i.e. at runtime. This is what happens on Linux/Mac OS X. According to the dlopen doc:
This can be easily confirmed with Now, before doing any change to this, I would like to know more about the differences with Windows. Can we achieve the same behavior with |
||
|
|
||
| # Make sure all symbols are defined. | ||
| # See: | ||
|
|
||
| +3 −0 | common.hh | |
| +1 −1 | common/starting-point.cc | |
| +8 −9 | tests.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With ltld-win32, we can use this, i.e. pkg-config check on Windows, and fallback to the current check for other platforms.