-
-
Notifications
You must be signed in to change notification settings - Fork 13
Added support of RR 2025 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe version constraint for the "spiral/roadrunner" dependency in the "require" section of Changes
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
composer.json (1)
41-49: Keeprequirekeys alphabetically ordered. With"config": { "sort-packages": true }enabled, it’s a good practice to maintain alphabetical order in therequiresection. The proper sequence is:
spiral/goridgespiral/roadrunnerspiral/roadrunner-workerReordering now avoids unnecessary diffs when Composer auto-sorts on update.
composer.json
Outdated
| "spiral/roadrunner-worker": "^3.0", | ||
| "spiral/goridge": "^4.0", | ||
| "spiral/roadrunner": "^2024.3" | ||
| "spiral/roadrunner": "^2024.3 | ^2025.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect version constraint operator. Composer semver uses || for logical OR, not a single |, and it’s best to avoid spaces around it. Please update to:
"spiral/roadrunner": "^2024.3||^2025.1"This will ensure Composer correctly parses and installs either 2024.3-series or 2025.1-series releases.
ignore Psalm override errors
Summary by CodeRabbit