Skip to content

handle nulls during cast for like op for ch#8846

Merged
nishantmonu51 merged 4 commits intomainfrom
ch_like_nullable
Feb 16, 2026
Merged

handle nulls during cast for like op for ch#8846
nishantmonu51 merged 4 commits intomainfrom
ch_like_nullable

Conversation

@pjain1
Copy link
Member

@pjain1 pjain1 commented Feb 13, 2026

To prevent errors like

Error Message
Code: 349. DB::Exception: Cannot convert NULL value to non-Nullable type: while executing 'FUNCTION CAST(<>: 0, 'TEXT'_String :: 1) -> CAST(<>, 'TEXT'_String) String : 3': While executing MergeTreeSelect(pool: PrefetchedReadPool, algorithm: Thread). (CANNOT_INSERT_NULL_IN_ORDINARY_COLUMN) (version 25.10.1.7375 (official build)) @

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Copy link
Collaborator

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can we add a unit test as well ?

@pjain1
Copy link
Member Author

pjain1 commented Feb 16, 2026

@nishantmonu51 added test

@pjain1 pjain1 requested a review from nishantmonu51 February 16, 2026 05:24
@nishantmonu51 nishantmonu51 merged commit e8dc1aa into main Feb 16, 2026
11 checks passed
@nishantmonu51 nishantmonu51 deleted the ch_like_nullable branch February 16, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants