This repository was archived by the owner on Nov 12, 2024. It is now read-only.
docs(types.ts): add rotate() example#843
Open
SG-SWE073 wants to merge 3 commits intoreplit:masterfrom
Open
Conversation
lajbel
suggested changes
Apr 7, 2024
src/types.ts
Outdated
Comment on lines
236
to
239
| * sprite("bean"), | ||
| * pos(200,140), | ||
| * anchor("center"), | ||
| * rotate(-90), |
Contributor
There was a problem hiding this comment.
There should be indentation.
src/types.ts
Outdated
Comment on lines
233
to
234
| * // bean WITH anchor: rotates bean based on sprite center | ||
| * // bean WITHOUT anchor: rotates bean relative to local space |
Contributor
There was a problem hiding this comment.
I feel this explanation makes no sense, all objects have a default achor and it is topleft.
Contributor
Author
There was a problem hiding this comment.
So I noticed that without anchor("center"), it will rotate the sprite on a different origin, or in this case the default anchor top left, but if I wanted to rotate the sprite without changing it's position at all, I'd use anchor("center"). I will rewrite the explanation to be more clear about that.
src/types.ts
Outdated
| * ```js | ||
| * // bean WITH anchor: rotates bean based on sprite center | ||
| * // bean WITHOUT anchor: rotates bean relative to local space | ||
| * const rotateBean = add([ |
Contributor
There was a problem hiding this comment.
The variable should be rotatedBean or simply bean
- Changed variable name to "bean" - Added indents - Made comment description more clear
- Made "with" and "without" lowercase - Changed the description again
Contributor
Author
|
Updated again with those minor adjustments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rotate() example