add asyncCall as an action parameter, #26
Open
FredericHeem wants to merge 2 commits intoreflux:masterfrom
Open
add asyncCall as an action parameter, #26FredericHeem wants to merge 2 commits intoreflux:masterfrom
FredericHeem wants to merge 2 commits intoreflux:masterfrom
Conversation
test/creatingActions.spec.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it.only("should create action with the parameter asyncCall",function(done){ |
Contributor
|
Given that promise support is broken out into the reflux-promise project, we'll have to figure out if this feature is suitable for reflux-core. I definitely do see why this feature may be desirable, but it needs to be balanced against keeping a fairly simple, not-too-too-magical core. In any case thanks for the contribution! We'll try to figure it out soon. CC @spoike @benglass. |
Author
|
Thanks for the catch, the |
Author
|
Any news on that PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to avoid calling directly listenAndPromise, instead, pass the function as a new action parameter
asyncCallBefore:
After: