Skip to content

Conversation

@alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Nov 8, 2024

We currently have

src/Data/Patch.hs:33:1: warning: [-Wunused-imports]
    The qualified import of ‘Data.Semigroup.Additive’ is redundant
   |
33 | import qualified Data.Semigroup.Additive as X
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

By doing

+  , module Y
   ) where
 
 import Data.Semigroup.Commutative
@@ -30,7 +31,7 @@ import Data.Semigroup (Semigroup (..))
 
 -- N.B. Intentionally reexporting `Additive`, the deprecated alias, as
 -- this is a reexport for backwards compatibility.
-import qualified Data.Semigroup.Additive as X
+import qualified Data.Semigroup.Additive as Y

we get

src/Data/Patch.hs:14:5-12: warning: [GHC-64649] [-Wdodgy-exports]
    The export item ‘module Y’ exports nothing
   |
14 |   , module Y
   |     ^^^^^^^^
src/Data/Patch.hs:34:1-45: warning: [-Wunused-imports]
    The qualified import of ‘Data.Semigroup.Additive’ is redundant
   |
34 | import qualified Data.Semigroup.Additive as Y
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

whereas removing qualified makes the warning go away in both X and Y cases.

I don't get it either but ghc 8.4 and 9.10 agree on this

@alexfmpe alexfmpe merged commit 91f44a9 into reflex-frp:develop Nov 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants