Implements num_traits::real::Real for NotNan<T>#176
Merged
mbrubeck merged 2 commits intoreem:masterfrom Aug 22, 2025
DouisLavid:master
Merged
Implements num_traits::real::Real for NotNan<T>#176mbrubeck merged 2 commits intoreem:masterfrom DouisLavid:master
mbrubeck merged 2 commits intoreem:masterfrom
DouisLavid:master
Conversation
…oatCore Forwards the calls of Real trait methods to the underlying type, panicking when the result is NaN, as suggested in https://docs.rs/num-traits/latest/num_traits/real/trait.Real.html Also adds a few tests to ensure things actually panic when they should.
Collaborator
|
Looks like this code needs to require |
|
@mbrubeck can you release a new version so we can get this on crates.io? thanks! |
Collaborator
|
Published as version 5.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the counterpart of the implementation of Float for OrderedFloat as Real is "A trait for real number types that do not necessarily have floating-point-specific characteristics such as NaN and infinity."
Operations that would result in a NaN cause a panic, as it is the behaviour that it suggested in the num_trait docs. Checks for NaN results are only done in cases where a NaN could be expected, and assumes that the implementation of Real for the underlying type is sane otherwise.