Added multiple e2e variants #2108
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+16
to
+17
| const getStateFile = (variantName) => | ||
| resolve(__dirname, '..', `.testcontainers-state-${variantName}.json`); |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| const getStateFile = (variantName) => | |
| resolve(__dirname, '..', `.testcontainers-state-${variantName}.json`); | |
| const getStateFile = (variantName) => resolve(__dirname, '..', `.testcontainers-state-${variantName}.json`); |
Comment on lines
+23
to
+26
| redpandaKafka: 19092, | ||
| redpandaSchemaRegistry: 18081, | ||
| redpandaAdmin: 19644, | ||
| kafkaConnect: 18083, |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| redpandaKafka: 19092, | |
| redpandaSchemaRegistry: 18081, | |
| redpandaAdmin: 19644, | |
| kafkaConnect: 18083, | |
| redpandaKafka: 19_092, | |
| redpandaSchemaRegistry: 18_081, | |
| redpandaAdmin: 19_644, | |
| kafkaConnect: 18_083, |
Comment on lines
+31
to
+34
| redpandaKafka: 19192, | ||
| redpandaSchemaRegistry: 18181, | ||
| redpandaAdmin: 19744, | ||
| kafkaConnect: 18183, |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| redpandaKafka: 19192, | |
| redpandaSchemaRegistry: 18181, | |
| redpandaAdmin: 19744, | |
| kafkaConnect: 18183, | |
| redpandaKafka: 19_192, | |
| redpandaSchemaRegistry: 18_181, | |
| redpandaAdmin: 19_744, | |
| kafkaConnect: 18_183, |
Comment on lines
+36
to
+38
| destRedpandaKafka: 19193, | ||
| destRedpandaSchemaRegistry: 18191, | ||
| destRedpandaAdmin: 19745, |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| destRedpandaKafka: 19193, | |
| destRedpandaSchemaRegistry: 18191, | |
| destRedpandaAdmin: 19745, | |
| destRedpandaKafka: 19_193, | |
| destRedpandaSchemaRegistry: 18_191, | |
| destRedpandaAdmin: 19_745, |
| writeFileSync(licensePath, process.env.ENTERPRISE_LICENSE_CONTENT); | ||
| } else { | ||
| const defaultLicensePath = resolve(__dirname, '../../../console-enterprise/configs/shared/redpanda.license'); | ||
| const defaultLicensePath = resolve(__dirname, '../../../../console-enterprise/frontend/tests/config/redpanda.license'); |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| const defaultLicensePath = resolve(__dirname, '../../../../console-enterprise/frontend/tests/config/redpanda.license'); | |
| const defaultLicensePath = resolve( | |
| __dirname, | |
| '../../../../console-enterprise/frontend/tests/config/redpanda.license' | |
| ); |
Comment on lines
812
to
814
| console.log( | ||
| `🚀 GLOBAL SETUP STARTED ${isEnterprise ? '(ENTERPRISE MODE)' : '(OSS MODE)'}${needsShadowlink ? ' + SHADOWLINK' : ''}` | ||
| `🚀 GLOBAL SETUP: ${variantName}${needsShadowlink ? ' + SHADOWLINK' : ''}` | ||
| ); |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| console.log( | |
| `🚀 GLOBAL SETUP STARTED ${isEnterprise ? '(ENTERPRISE MODE)' : '(OSS MODE)'}${needsShadowlink ? ' + SHADOWLINK' : ''}` | |
| `🚀 GLOBAL SETUP: ${variantName}${needsShadowlink ? ' + SHADOWLINK' : ''}` | |
| ); | |
| console.log(`🚀 GLOBAL SETUP: ${variantName}${needsShadowlink ? ' + SHADOWLINK' : ''}`); |
| configFile, | ||
| isEnterprise, | ||
| needsShadowlink, | ||
| ports |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| ports | |
| ports, |
Comment on lines
+11
to
+12
| const getStateFile = (variantName) => | ||
| resolve(__dirname, '..', `.testcontainers-state-${variantName}.json`); |
Contributor
There was a problem hiding this comment.
[Biome] reported by reviewdog 🐶
Suggested change
| const getStateFile = (variantName) => | |
| resolve(__dirname, '..', `.testcontainers-state-${variantName}.json`); | |
| const getStateFile = (variantName) => resolve(__dirname, '..', `.testcontainers-state-${variantName}.json`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to create multiple e2e variants (with different BE configurations + owlshop configs) for different e2e tests.
Note to self: enterprise tests fail for me in master after recent changes, so I need to solve this first. I think it might be related to https://github.com/redpanda-data/console/pull/2103/changes