[Faults] Add support for matching on the host/authority header. #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiramSilvey
force-pushed
the
add-host-support
branch
from
42c9141 to
b0c41a2
Compare
HiramSilvey
changed the title
The PRs adding this to bpv2 have already been approved, and this PR is just to get bpv0 up-to-date with those. This introduces support for a new `h` parameter in the fault configuration header value. Specifically, if the `h` parameter is present, then the value of it will be checked against the host/authority header of the outgoing request before determining whether the request matches for fault injection. Note that this is _not_ supported for gRPC due to the authority header not being exposed by client-middleware runtime. If you'd like more info on the workaround for gRPC, I'm happy to DM information on what we plan to do. Fix lint error
HiramSilvey
force-pushed
the
add-host-support
branch
from
b0c41a2 to
a5d7814
Compare
HiramSilvey
requested review from
fishy,
kylelemons and
pacejackson
and removed request for
a team
fishy
reviewed
Jul 14, 2025
pacejackson
reviewed
Jul 14, 2025
Co-authored-by: Andrew Boyle <pacejackson@users.noreply.github.com>
pacejackson
reviewed
Jul 14, 2025
pacejackson
reviewed
Jul 14, 2025
Contributor
pacejackson
left a comment
pacejackson
left a comment
There was a problem hiding this comment.
one last small style suggestion
Co-authored-by: Andrew Boyle <pacejackson@users.noreply.github.com>
pacejackson
approved these changes
Jul 14, 2025
fishy
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRs adding this to bpv2 have already been approved, and this PR is just to get bpv0 up-to-date with those.
This introduces support for a new
hparameter in the fault configuration header value. Specifically, if thehparameter is present, then the value of it will be checked against the host/authority header of the outgoing request before determining whether the request matches for fault injection.Note that this is not supported for gRPC due to the authority header not being exposed by client-middleware runtime. If you'd like more info on the workaround for gRPC, I'm happy to DM information on what we plan to do.