This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Adapt use of with_indifferent_access so it works on and after rails 5.1#72
Open
renandhein wants to merge 1 commit intoreasoncorp:masterfrom
Open
Adapt use of with_indifferent_access so it works on and after rails 5.1#72renandhein wants to merge 1 commit intoreasoncorp:masterfrom
renandhein wants to merge 1 commit intoreasoncorp:masterfrom
Conversation
Member
|
thank you for posting this! I'll do my best to get it merged in quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of rails 5.1, ActionController::Parameters drifts further away from behaving like a simple Hash and the direct use of rails' with_indifferent_access method over it that was already deprecated now causes an error.
This is a simple fix to transform received options on dossier initialization to a hash when they are ActionController::Parameters so that we can continue using with_indifferent_access and keep everything that comes afterwards working as intended.
This is the only incompatibility I've found so far using dossier in an application running on Rails 5.1.