return 401 instead of 403 on missing token#11
Open
lefnire wants to merge 1 commit intorealpython:masterfrom
Open
return 401 instead of 403 on missing token#11lefnire wants to merge 1 commit intorealpython:masterfrom
lefnire wants to merge 1 commit intorealpython:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been poking around on auth error codes (401 vs 403) and I think that 403 is used specifically for "you don't have sufficient privileges". Ie, "you're requesting an admin resource but you're only a piddly user". So TMK where we're lacking an
auth_token, it should still be a 401. Feel free to close if I'm wrong