Fix incorrect libm linking on VS2022 in CMake project#27
Open
landiluigi746 wants to merge 2 commits intoraysan5:masterfrom
Open
Fix incorrect libm linking on VS2022 in CMake project#27landiluigi746 wants to merge 2 commits intoraysan5:masterfrom
landiluigi746 wants to merge 2 commits intoraysan5:masterfrom
Conversation
landiluigi746
force-pushed
the
fix_vs_linking_cmake
branch
from
1a2a37b to
dc5f9a4
Compare
|
I also had this same problem, and had the same solution. Hope this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that libm (-lm) was unconditionally linked in the CMake project, even if using MSVC, which doesn't have libm.
I also added an option to disable default logging in the CMake project