Skip to content

Fix multi-GPU All Neighbors memory coherence issue on older platforms #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
viclafargue wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix multi-GPU All Neighbors memory coherence issue on older platforms #1713

viclafargue wants to merge 4 commits into from

Conversation

@viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Jan 20, 2026

@viclafargue viclafargue requested a review from jinsolp January 20, 2026 15:34
@viclafargue viclafargue requested a review from a team as a code owner January 20, 2026 15:34
@viclafargue viclafargue added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 20, 2026
jinsolp
jinsolp reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @viclafargue thanks for working on this!

dantegd
dantegd requested changes Jan 22, 2026
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just some minor suggestions alongside @jinsolp review

dantegd
dantegd approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI passing

jinsolp
jinsolp approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dantegd dantegd dantegd approved these changes

@jinsolp jinsolp jinsolp approved these changes

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Vector Search, ML, & Data Mining Release Board
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] test_umap_trustworthiness_on_batch_nnd test failure with multiple GPUs

4 participants

@viclafargue @dantegd @jinsolp @divyegala