-
Notifications
You must be signed in to change notification settings - Fork 1
Remove workspace inheritance for external consumption #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughReplaced workspace-derived package metadata and dependency placeholders in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Tip For best results, initiate chat on the files or code changes. SIZE=M 🧠 Learnings used |
Motivation
When
rain-math-floatis consumed as a path dependency from external repositories (via nested submodules), cargo cannot resolve workspace inheritance fields likeversion.workspace = true. This causes build failures when traversing the dependency chain from repositories like st0x-rest-api → rain.orderbook → rain.interpreter → rain.interpreter.interface → rain.math.float.Solution
Replace workspace inheritance in
crates/float/Cargo.tomlwith explicit values:This allows the crate to be built correctly when cargo traverses path dependencies from outside the workspace.
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit