Skip to content

Conversation

@findolor
Copy link
Contributor

@findolor findolor commented Feb 4, 2026

Motivation

When rain-math-float is consumed as a path dependency from external repositories (via nested submodules), cargo cannot resolve workspace inheritance fields like version.workspace = true. This causes build failures when traversing the dependency chain from repositories like st0x-rest-api → rain.orderbook → rain.interpreter → rain.interpreter.interface → rain.math.float.

Solution

Replace workspace inheritance in crates/float/Cargo.toml with explicit values:

version = "0.1.0"
edition = "2021"
license = "LicenseRef-DCL-1.0"
homepage = "https://github.com/rainlanguage/rain.math.float"

This allows the crate to be built correctly when cargo traverses path dependencies from outside the workspace.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Chores
    • Updated package metadata and dependency declarations in the float crate to use explicit values and fixed versions instead of workspace defaults.
  • Style
    • Minor import reorderings with no functional or behavioral changes.

@findolor findolor self-assigned this Feb 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Walkthrough

Replaced workspace-derived package metadata and dependency placeholders in crates/float/Cargo.toml with explicit crate-level values and versions; reordered a few imports in crates/float/src/* (no behavioral changes).

Changes

Cohort / File(s) Summary
Crate manifest (package & deps)
crates/float/Cargo.toml
Replaced *.workspace = true package fields with explicit values (version, edition, license, homepage) and replaced workspace dependency placeholders with fixed versions and feature lists for alloy, thiserror, serde, revm, proptest, etc., across [dependencies], target-specific deps, and [dev-dependencies].
Source import reordering
crates/float/src/evm.rs, crates/float/src/lib.rs
Non-functional reordering of import statements (moved EthPrecompiles position; swapped import order of B256/Bytes and fixed_bytes/U256).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • create rust float lib #46 — Modifies the same crate manifest and dependency/version fields in crates/float/Cargo.toml; likely related.

Suggested reviewers

  • hardyjosh
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove workspace inheritance for external consumption' accurately summarizes the main change: replacing workspace inheritance with explicit dependency values to support external path consumption.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/workspace-inheritance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister merged commit e10459d into main Feb 5, 2026
10 checks passed
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Tip

For best results, initiate chat on the files or code changes.

SIZE=M


🧠 Learnings used
Learnt from: 0xgleb
Repo: rainlanguage/rain.math.float PR: 46
File: .github/workflows/rainix.yaml:4-6
Timestamp: 2025-06-11T10:46:58.363Z
Learning: For GitHub Actions workflows in this repository, the maintainer prefers using `${{ github.ref }}` (full ref path) in the `concurrency.group` key to ensure correct run-cancellation behavior, even if it is less readable than `${{ github.ref_name }}`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants