Skip to content

cancun #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 1 commit into from
Dec 6, 2025
Merged

cancun #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ solc = "0.8.25"
optimizer = true
optimizer_runs = 100000

# pre push0 for maximum compatibility
evm_version = "paris"
evm_version = "cancun"
Copy link

@coderabbitai coderabbitai bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Read the foundry.toml file to see full context
cat foundry.toml

Repository: rainlanguage/rain.factory

Length of output: 478

🏁 Script executed:

# Search for any references to Cancun or Paris EVM versions in the codebase
rg -i "cancun|paris" --type-list | head -20

Repository: rainlanguage/rain.factory

Length of output: 458

🏁 Script executed:

# Look for Solidity code that might use push0 or other Cancun opcodes
rg "push0|mcopy|tstore|tload" --type solidity

Repository: rainlanguage/rain.factory

Length of output: 101

🏁 Script executed:

# Check for any documentation or comments about EVM version requirements
rg -i "evm.*version|cancun|paris" . --type md --type txt

Repository: rainlanguage/rain.factory

Length of output: 51

🏁 Script executed:

# Check git history for this file if available
git log --oneline foundry.toml 2>/dev/null | head -10

Repository: rainlanguage/rain.factory

Length of output: 83

Provide context for the EVM version upgrade and verify Cancun compatibility.

The EVM version has been upgraded from "paris" to "cancun", and the preceding compatibility comment has been removed. However, this change lacks documented motivation or context.

Before approving:

  1. Clarify the rationale: Why is the project upgrading to Cancun? Are new Cancun opcodes required, or is this general modernization?
  2. Verify compatibility: Confirm that all existing contracts have been tested against the Cancun EVM without breaking changes.
  3. Document implications: If this affects downstream users or deployed contracts, communicate clearly.
🤖 Prompt for AI Agents 
In foundry.toml around line 12, the EVM version was changed to "cancun" without
context or verification; add a brief comment above evm_version explaining the
rationale for upgrading (e.g., required Cancun opcodes or modernization), run
and document full test coverage of all existing contracts against the Cancun EVM
(unit/integration and any gas/bytecode comparisons) to confirm no breaking
changes, and update project/docs/CHANGELOG or include a note for downstream
users about potential implications; if compatibility cannot be confirmed, revert
to the previous version until testing and communication are complete.


# Build metadata used for testing rain meta aware contracts in this folder rather
# than expose ffi to forge.
Expand Down