Fix popups/Shiny-events for *Src-functions#46
Closed
trafficonese wants to merge 4 commits intor-spatial:masterfrom
Closed
Fix popups/Shiny-events for *Src-functions#46trafficonese wants to merge 4 commits intor-spatial:masterfrom
trafficonese wants to merge 4 commits intor-spatial:masterfrom
Conversation
Collaborator
Author
|
I'll close my other PRs as they are all nox included in #95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes popups and Shiny-click events work with *Src functions.
Also, since
layerIdis normally a vector, I changed how the attributes in JS are read. They now take thegroupinstead oflayerId.But actually I think we should create a random name internally, because now it's not possible to include multiple layers with the same
group.Also
groupandlayerIdmay contain Umlauts or whitespaces, which currently throws this error in a Shiny app: