This repository was archived by the owner on Dec 13, 2019. It is now read-only.
feat(QInput, QChipsInput, QUploader): Add custom loading slot as QBtn#586
Open
jcperez-ch wants to merge 1 commit intoquasarframework:devfrom
Open
feat(QInput, QChipsInput, QUploader): Add custom loading slot as QBtn#586jcperez-ch wants to merge 1 commit intoquasarframework:devfrom
jcperez-ch wants to merge 1 commit intoquasarframework:devfrom
Conversation
Merged
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR introduces the
loadingslot to components:QInputQChipsInputQUploaderIt emulates the behaviour of
QBtnof having a custom UI that indicates that the component is loading instead of the default themeQSpinner. This keeps consistency of spinners when using customQSpinner.*or any other way to indicateloadingstates.